search

tnfe / FFCreator

A fast video processing library based on node.js (一个基于node.js的高速视频制作库)
http://tnfe.github.io/FFCreator/
MIT License
2.85k stars 405 forks source link

添加translation时长校验 #282

Closed zdu-strong closed 1 year ago

zdu-strong commented 2 years ago

现在, translation没有translation时长校验, 任意设置translation时长可能会导致以下错误. image

代码如下. 由于场景1与场景2的过渡时长为5秒, 场景2与场景3的过渡时长为1秒, 意味着场景2最长需要有6秒的时长. 现在场景2的时长是5秒, 是不够的. image

drawcall commented 2 years ago

哦 欢迎提交pr

zdu-strong commented 2 years ago

很好, 我将添加一个检查, 在FFCreator.start()方法里进行调用.

zdu-strong commented 2 years ago

Pull Request 添加过渡时长的检查 已经在路上. 请查收.

zdu-strong commented 2 years ago

哦 欢迎提交pr

Please check the pull request

fantasticsoul commented 2 years ago

帮你催了一下看看PR，再等等哈

zdu-strong commented 2 years ago

帮你催了一下看看PR，再等等哈

Thank you so much

drawcall commented 2 years ago

Wait a minute. Check any things later.

zdu-strong commented 2 years ago

Although I know FFCreator.addChild(FFScene), so check transition duration of all FFScene. But I'm ignoring whether FFCreator can add other types of children, and whether they affect the transition duration.

Please let me know if this is clear to you.