tnicola / ngx-joyride

Angular Joyride/Tour library
https://tnicola.github.io/ngx-joyride/
MIT License
245 stars 96 forks source link

Using Translating Strings in Title #16

Closed arorakanav closed 5 years ago

arorakanav commented 6 years ago

I am trying send the title string as :

<a joyrideStep="name"
[title]="'app.transaltion.name' | translate">

At runtime the title is empty!!

tnicola commented 6 years ago

Hi @arorakanav11 , Which translation library are you using? Is it your KEY app.transaltion.name the right one?I see a typo in transaltion. Anyway, I've tried with @ngx-translate/core and it works fine.

wafimardini commented 5 years ago

Hi There I wasn't able to use title translation we do use custom pipe to sync from google usually we use it in this way: {{'Translate what ever text' | googletranslate | async}} [title]= "'Dashboard' | googletranslate | async " ... show text but apply any translation

Any suggestion? Thanks in advance

tnicola commented 5 years ago

Hi @wafimardini , Yes, you're right, the problem is that the directive accepts only sync @Inputs for now. I'm working to add the possibility to pass also async data.

rokulis commented 5 years ago

Hey, are you looking into the solution for ngx http loader? Maybe I can help you?

tnicola commented 5 years ago

@taskiukas No, I was looking for a solution for passing async text to the joyride step. Thanks anyway for your help!

tnicola commented 5 years ago

@wafimardini , @arorakanav11 This bug has been fixed in the new version: 2.2.3