tnicola / ngx-joyride

Angular Joyride/Tour library
https://tnicola.github.io/ngx-joyride/
MIT License
245 stars 95 forks source link

Can't set dark mode with CSS class #480

Closed DiogoParrinha closed 2 years ago

DiogoParrinha commented 2 years ago

Describe the bug To set dark mode I have added a CSS class to the body tag. Apparently this works well when using ionic serve and in an Android emulator (ionic + capacitor).

However, in a real device it doesn't seem to work in all the cases because for some devices the joyride gets added within the app root, whereas in some cases it gets added outside it, so it's not even within the body tag.

I guess this could easily be fixed if we could have a property to set a custom CSS tag.

To Reproduce Steps to reproduce the behavior:

  1. Try to set a parent CSS class to joyride
  2. It's not possible

Expected behavior Even with a workaround to set the dark mode CSS class on the body should work, but because the joyride tag is outside it in the device tests, it doesn't affect the joyride content.

Screenshots N/A

Details (please complete the following information):

Additional context Add any other context about the problem here.

DiogoParrinha commented 2 years ago

It seems like this was a caching issue and it's resolved now after clearing the application cache 🤷