tno-terminology-design / tev2-specifications

The Terminology Engine (v2) is a set of specifications and tools that caters for the creation and maintenance (i.e. curation) of terminologies, as well as for its subsequent use in publications of different types (e.g. websites, whitepapers) and formats (e.g. html, LaTeX), as appropriate for different, individual scopes.
https://tno-terminology-design.github.io/tev2-specifications
1 stars 2 forks source link

tev2-specification does not replicate on another github user account's github pages #29

Closed henkvancann closed 8 months ago

henkvancann commented 8 months ago

I've forked

tev2-specification from tno-terminology-design to https://github.com/henkvancann/tev2-specifications

Because intent to work in a branch 'hvc' (my initials), I've added the new branch to the invocation list of github actions.

You can see here that the Docs_deploy action script falters: https://github.com/henkvancann/tev2-specifications/actions/runs/8019370132/job/21907096531

A run with Act (local virtual github action) gives the same results.

These are my github user setting for Pages: Screenshot 2024-02-23 at 14 57 30

RieksJ commented 8 months ago

@Ca5e pls check out the log. it seems rhat the mrgt doesnt catch this error and thus doesnt produce a good error message end dies. could that be caused by the new tools?

Ca5e commented 8 months ago

The MRGT is working as intended, but the error message fails to include the files that were causing the issue (I'll fix this for the next version). The terms that were copied include duplicate formPhrases, in this case concept:tools, caused by the tev2-tool.md including tool{ss} and tev2-toolbox.md including tools in their formPhrases field.

The error is caused by the updated tools, in the sense that not all previous versions checked for this issue.

image

RieksJ commented 8 months ago

@Ca5e tnx. when the new tool is published, can you say so in this iissue?

Ca5e commented 8 months ago

Version 1.1.2 of the MRGT was just published, and now reports the following.

image

RieksJ commented 8 months ago

@Ca5e does this generate a hard error or does thetool continue as it does with other errors? which i currently think it should

@henkvancann i fixed the cause in the tev2 specs repo. copying the fix should get you going again

Ca5e commented 8 months ago

@Ca5e does this generate a hard error or does thetool continue as it does with other errors? which i currently think it should

It currently halts the output of the MRG and stops the program with an error code. This could of course be changed to only logging an error, which would mean the MRG could be output with duplicates. I believe you'd want the last option?

@henkvancann i fixed the cause in the tev2 specs repo. copying the fix should get you going again

I believe the issue was already solved in this commit from a few weeks back, I think there's no match for tools now.

RieksJ commented 8 months ago

@Ca5e yes for now. its not ideal. we are increasingly looking for someone to make a start with the integrity checker tool....

Ca5e commented 8 months ago

I've just published MRGT v1.1.3, which only logs the error and doesn't halt the program. A rerun of the workflow should therefore run normally.

henkvancann commented 8 months ago

Screenshot 2024-02-25 at 13 44 31