MRGT producess error without saying which file caused the problem

tno-terminology-design / tev2-tools

The Terminology Engine (v2) is a set of specifications and tools that caters for the creation and maintenance (i.e. curation) of terminologies. This repository contains the sources for the tools.

Apache License 2.0

2 stars 3 forks source link

MRGT producess error without saying which file caused the problem #14

Closed RieksJ closed 11 months ago

RieksJ commented 11 months ago

Here is the proof:

The error was caused by the frontmatter having two items called glossaryTerm, and has been fixed in the meantime.

The bug here is that

while the line and column numbers were provided, the filename was not. This bug might also exist in other tools, as it seems a rather generic one.
the MRGT crashes (rather than continuing with the next curated text file), which means that other, similar errors only get noticed when this error is fixed and you bump into the next.

Ca5e commented 11 months ago

You're correct! The error should not fall back all the way to the instruction, instead it should be recognized that something went wrong while loading a curated text. I've added a try/catch block so a similar error will now look like this, continuing after the error is shown. I've noted this issue so I can correct this in other tools as well if it exists. I still want to go over every possible error case in the near future.