tno-terminology-design / tev2-tools

The Terminology Engine (v2) is a set of specifications and tools that caters for the creation and maintenance (i.e. curation) of terminologies. This repository contains the sources for the tools.
Apache License 2.0
2 stars 3 forks source link

Add ingress tool #17

Closed brianorwhatever closed 6 months ago

brianorwhatever commented 9 months ago

@Ca5e @RieksJ Adding the ingress tools for wikis

RieksJ commented 9 months ago

Nice to see non-TNOers contribute to the tools development.

This comment is only about necessary updates to the tev2-specifications repo. @Ca5e, @Michiel-s: could you do a review of the code?

Please reconsider the name of the tool. 'Ingress' sounds generic, but the tool only does (specific) wiki's. How about wiki-ingress?

Regarding additions to the tev2-specifications, I would expect to see:

Ca5e commented 7 months ago

The observations below are my first observations, mostly from comparing the tool to the other tools within the repo.

RieksJ commented 6 months ago

@brianorwhatever: last week, the maintenance of the repo has officially been transferred to TNO's Semantic Treehouse (STH) development team, of which @Michiel-s is the group lead. When discussing this pull request, he mentioned that the STH dev-team welcomes contributions to the opern-source tools that they maintain, but there are a few rules for that.

One such rule is that a contribution for a new tool/feature must be of such a generic nature that it warrants its maintenance to be taken on by the STH dev team. The reason is that if people start adding all sorts of features, this would increase the maintenance burden of the dev team and it would soon become too much to handle.

Having looked a bit at this PR, the dev team thinks it is serves too specific a goal to warrant it becoming a part of the tev2 itself. The path that this tool should take in their opinion is that it should be maintained elsewhere, e.g., within the context of TOIP (as a TOIP repo), where it could then still use the TEv2 tools as they are just npm packages.

I suggest that based on this feedback, we should close this PR and take it to the CTWG group for discussing how to further proceed.

RieksJ commented 6 months ago

Closing this PR as per my previous comment. If that's incorrect, pls. reopen it.