Closed brianorwhatever closed 6 months ago
Nice to see non-TNOers contribute to the tools development.
This comment is only about necessary updates to the tev2-specifications repo. @Ca5e, @Michiel-s: could you do a review of the code?
Please reconsider the name of the tool. 'Ingress' sounds generic, but the tool only does (specific) wiki's. How about wiki-ingress
?
Regarding additions to the tev2-specifications, I would expect to see:
41-ingressable-wiki-file.md
, with a structure similar to the other file specifications in that directory. Its contents should enable a reader to determine what is, and what is not, an ingressable wiki file.31-wiki-ingress.md
(if that's what the tool will be called), with a structure similar to the other tool specifications in that directory. Its contents should enable a reader that knows how to execute a program but is not a developer, to install and run the program from the commandline. Wiki Ingress
(if that's what the tool is called). It contents should document all tool-specific fields in the config file (similar to the options on the command line) that the tool uses.21-wiki-setup
, the contents of which should be readable by curators that want to create/organize a TEv2-enabled github/gitlab repo that uses the wiki-ingress tool. It would tell them not just the technical things to be arranged, but also that they would need to have some 'ingress procedure', i.e. their way of working for transferring the wiki pages into curated texts. Stuff like this may need to be discussed in ToIP/CTWG first.22-wiki-authoring.md
, the contents of which should be a readable for people in the ToIP CTWG meeting (e.g., Nicky), and they would then know how to structure the pages in a wiki that they already use for their purposes.The observations below are my first observations, mostly from comparing the tool to the other tools within the repo.
parse
is executed twice on program
, and editing how errors are thrown at the base level. In this sense the code is not wrong, but I would match these before integrating. This tool also still says The CLI for the Term Reference Resolution Tool
.writeFile
instead of the local saveToFile
. Also reusing the logger that is used by all of the tools would be nice.config.yaml
to __tests__/content/terminology-config.yaml
. Although the actual automated test doesn't work yet, it would be nice to also add the ingress-wiki to this, so it can be run/tested in a similar manner.@brianorwhatever: last week, the maintenance of the repo has officially been transferred to TNO's Semantic Treehouse (STH) development team, of which @Michiel-s is the group lead. When discussing this pull request, he mentioned that the STH dev-team welcomes contributions to the opern-source tools that they maintain, but there are a few rules for that.
One such rule is that a contribution for a new tool/feature must be of such a generic nature that it warrants its maintenance to be taken on by the STH dev team. The reason is that if people start adding all sorts of features, this would increase the maintenance burden of the dev team and it would soon become too much to handle.
Having looked a bit at this PR, the dev team thinks it is serves too specific a goal to warrant it becoming a part of the tev2 itself. The path that this tool should take in their opinion is that it should be maintained elsewhere, e.g., within the context of TOIP (as a TOIP repo), where it could then still use the TEv2 tools as they are just npm packages.
I suggest that based on this feedback, we should close this PR and take it to the CTWG group for discussing how to further proceed.
Closing this PR as per my previous comment. If that's incorrect, pls. reopen it.
@Ca5e @RieksJ Adding the ingress tools for wikis