search

tno-terminology-design / tev2-tools

The Terminology Engine (v2) is a set of specifications and tools that caters for the creation and maintenance (i.e. curation) of terminologies. This repository contains the sources for the tools.
Apache License 2.0
2 stars 3 forks source link

Problems with the processing of the `rename` instruction in the MRGT #41

Closed RieksJ closed 7 months ago

RieksJ commented 8 months ago

When using the MRGT on the tev2-specifications repo the result is this:

image

When generating mrg.tev2.documentation.yaml, the first instruction selects the term action from the essif-lab scope. Then, the subsequent rename instruction tells it to rename the term, modifying fields id and term to become act, and modifying the formphrases field to become act{ss}.

However, when I check the resulting mrg-file, I cannot find an entry for the renamed thing.

Note that the following termselection instruction again imports action from essif-lab. This should not overwrite the (renamed) act entry, but seems to do so.

Ca5e commented 8 months ago

The check for duplicates, which determines if an entry overwrites another entry within a provisional MRG, currently happens according to the termid property of an entry. I believe this issue stems from that, because the rename action doesn't alter the termid. I suppose this could be remedied by re-triggering the termid creation after a rename of the term or termType.

RieksJ commented 8 months ago

yes, please!

RieksJ commented 7 months ago

@Ca5e : This is (still) not fixed.

The SAF says this:

image

The log I just generated says this:

image

I didn't expect to see (line 61) that a term got overwritten. And if the rename instruction worked, then indeed the mrg-entry 'action' got overwritten.

Ca5e commented 7 months ago

I hadn't published the newest versions yet. I have just done so, the rerun on tev2-specifications seems to have fixed this.