search

tnobody / lerna-audit

Micro util to run npm audit in lerna monorepos
9 stars 11 forks source link

fix: Add --all flag to include private packages #1

Closed stieg closed 4 years ago

stieg commented 4 years ago

Without it lerna will only list non-private packages.

stieg commented 4 years ago

It could be done this way without problem but what I can't think of is a situation why a user might want to exercise such behavior with this tool. If they wish to limit scope of packages then it would be more valuable to support something like --scope argument like lerna instead of the --all argument mentioned above. Perhaps you have an example of why someone may wish not to invoke this script with --all?

tnobody commented 4 years ago

Hi @stieg,

sorry, I'm just really careful when something looks like a breaking change to me. I had a little bit of time to think about the "problem" twice and my view on this had changed since I recognized that the tool cannot work properly when not all information about all packages is loaded at least.

So I'll going to merge this PR and release a new version.

Thanks for contribution 👍

stieg commented 4 years ago

sorry, I'm just really careful when something looks like a breaking change to me.

Don't be sorry. You are being cautious and that is wise. It's better to ask about it and decide its not an issue than just skip by it altogether.