tnodir / fort

Fort Firewall for Windows
GNU General Public License v3.0
1.11k stars 97 forks source link

`Show Program Alert Window` doesn't get the correct alerted/blocked program. #200

Closed Emi-Emi-Emi closed 5 months ago

Emi-Emi-Emi commented 5 months ago

The problem is simple, the Alert Window will display the very oldest detected program (with the alert icon) from the Program list, so if you never allowed or blocked a program, it will be showing in the alert window instead of the supposedly one being detected.

In my case vsce-sign.exe was added in the list of programs on December 19th, and that's the one being displayed when I tested this and got Store being alerted/blocked, and that means all the 20+ programs that got blocked but stayed in alert mode will have to be allowed or blocked for this to work fine.

Also, if you click, cancel, instead of allow, block or kill, it will stay in Alert mode, so any new alert program will go back to that program that was alerted before and display the window.

There is another issue, I tested in a clean profile, and since many programs get detected, well, if 10 programs got detected at a similar time, then it will not work as expected.

So, I don't know if there is a way to queue different alert program windows so you can go through them and check if you want to Allow or Block or kill them. And I don't know if a solution could be like the alert icon will disappear once you close Programs window, so only truly new detected programs will display the icon and people will review and know which ones were added since last time Program window was opened. This means once someone opens the dialog/Alert window, the icon will not exist in those programs since they were already 'reviewed' by people, and that way avoid alerted programs to exist only because the rules were never set to allow or block because Fort already set them that way and people aren't going to touch them anymore like happened on my side, where I have 23 alerted programs, and I might never edit them for that to disappear.

tnodir commented 5 months ago

Thanks for checking this new feature!

Ok, I'm going to:

tnodir commented 5 months ago

Please check the v3.11.1-test0.

Emi-Emi-Emi commented 5 months ago

Working so much better now! thank you.

BTW, can the Enter key be used to accept the whole dialog? The only use for Enter key in dialog is the Notes inputbox, after that, there is no use for enter unless you OK or Cancel, or change Drop down menu items like Groups or from In to at would make things faster to review, you open a program and hit enter to confirm to block a program and done.

I say focusing in Allow/Block/Kill process is better, because, this would mean users can use left and right arrow to change action and then hit enter to confirm it, all without having to hit tab key 20 times.

Of course the focusing in Allow/Block/Kill wouldn't be useful for the Wildcard Programs, since being focused in Wildcard Paths is useful there unlike the File Path in normal Programs.

But Enter means enter can be hit to all the programs in Review Alerts and quickly manage them. I know I can arrange column by alert and select them and hit B, but Auto Alert Window doesn't benefit from keyboard shortcuts, like using A and B or ctrl+alt+K to select the different modes, plus you still have to press Tab like 5 times to get to the OK button.

BTW, the OK button looks like it is highlighted even if hitting enter does nothing, that's why I thought Enter would work the way I suggest, until I saw it always looks highlighted.

image

tnodir commented 5 months ago

Please check the v3.11.1-test1.

Emi-Emi-Emi commented 5 months ago

Oh nice! 👍thanks!

Tiny minor issue, but when you open the Edit dialog, if it is set to Block, and you want to allow it, when you hit the left arrow key it will not be activated, it only gets enabled when you hit the right arrow key, which selects and highlights Block and then you can left key to go to allow. If you want to go from Block to Kill, you have to hit right key twice.

If you are in Kill process, and you want to change it to block or allow, if you left arrow key, it will not work, and then if you right arrow key will highlight Block, not the kill, and then you have to go to Kill, if not the radio enabled dot, will not be carried, so you can go from Block to allow, but it only moves the highlight, in that case you have to hit Spacebar, or go to kill and then 'grab' the dot, and then it will be moved with selection.

Allow is the only one that works as expected, only 1 press of key will go to Block.

Just reporting in case it can be fixed, but not like I mind. it works great and amazing job now it is easy to deal with the Alert Dialog without using mouse 👍

tnodir commented 5 months ago

Please check the v3.11.1-test2.

Also you can use "Ctrl+O" to open an advanced options menu.

tnodir commented 5 months ago

Implemented in v3.11.1.

Emi-Emi-Emi commented 5 months ago

Also you can use "Ctrl+O" to open an advanced options menu.

It opens but you can't use Tab or keyboard shortcuts (like UP and Down and spacebar) to select any option.

And Why is Kill process no in Review Alerted?, although Alert Window not having kill process makes more sense, doesn't mean a program can't be set to Kill, close it and let Fort do the job next time.

tnodir commented 5 months ago

It opens but you can't use Tab or keyboard shortcuts (like UP and Down and spacebar) to select any option.

Yes, I've to investigate it later..

And Why is Kill process no in Review Alerted?

It looks like overkill there). So I've added a workaround for you: Schedule the "Kill process" in 1 second. It'll apply (nearly) immediately.

Emi-Emi-Emi commented 5 months ago

Oh cool! thanks. Works great! Since Program is already running it won't be killed by Fort, so that works great.

tnodir commented 5 months ago

It opens but you can't use Tab or keyboard shortcuts (like UP and Down and spacebar) to select any option.

Fixed in v3.11.3.