tnodir / fort

Fort Firewall for Windows
GNU General Public License v3.0
1.1k stars 96 forks source link

Support for `/CLOSEAPPLICATIONS` on installer. #239

Closed Emi-Emi-Emi closed 2 months ago

Emi-Emi-Emi commented 2 months ago

Recently Winget decided to implement as default the /SUPPRESSMSGBOXES switch when upgrading apps, because they think the process should be as silent as it can (/verysilent), the problem is that if Fort is currently open, it should tell the user to close it to continue, but, instead of displaying the error about 'all instances' opened, as before, it will only throw an error to Terminal:

Starting package install...
Installer failed with exit code: 1
Installer log is available at:

and only the log with display the message:

Setup has detected that Fort Firewall is currently running.     
Please close all instances of it now, then click OK to continue, or Cancel to exit.

Which means users will either have issues upgrading, especially through winget, unless they know you have to close Fort first before running winget and/or they read the log or something.

I searched and found about inno offers CloseApplications, RestartApplications and CloseApplicationsFilter, but /closeapplications doesn't seem to be supported in the installer. So unless there is a technical reason why that is the case or there is a different name for a switch to do that, it would be nice if Fort allowed to be installed verysilently as Winget wants without any error message or user intervention, so people can upgrade through it without issues.

tnodir commented 2 months ago

Please check the v3.12.6.

Emi-Emi-Emi commented 2 months ago

working great!