search

tnonate / thenewoil

A project dedicated to teaching beginners and non-tech-savvy people about digital privacy and cybersecurity.
https://thenewoil.org
Other
15 stars 8 forks source link

Miscellaneous fixes to the contents of the articles #17

Closed src4026 closed 5 months ago

src4026 commented 6 months ago

Hi👋 Highly insightful website on guides to digital safety! A big thanks for the great work done on this website. While reading along, I noticed a couple of minor issues. Here's a PR with my proposed changes.

Changes

  1. "attack vetor" -> "attack vector"
  2. "...cars Pearson..." -> "...cars. Pearson"
  3. Added closing **s where they were missing in metadata.mdx & backups.mdx .
src4026 commented 6 months ago

Converted to draft because I noticed a potential typo in another page. I'll make the PR ready for review after I complete my reading of the entire website.

tnonate commented 5 months ago

Sorry it's taken me so long to reply to this. I appreciate you finding these errors! Definitely just let me know when you're ready and I'll review it.

src4026 commented 5 months ago

Sorry it's taken me so long to reply to this.

No worries!

Also, could you please have a look at my previous two commits and check whether they're what you intended. For some reason there were two asterisks that were escaped using \. I didn't realise that to bold-en in .mdx the same syntax as standard markdown is used.

src4026 commented 5 months ago

The same case for https://github.com/tnonate/thenewoil/pull/17/commits/a0a0648b012d6ac850c9b12924843dcef754e9c1

src4026 commented 5 months ago

Alright, the PR is ready for review. I haven't completed reading the entire website yet due to limitations I face currently, so this is all I have for now.

tnonate commented 5 months ago

I suck at using GitHub correctly. They all look right except for the Cryptomator one, that whole sentence should be bold and not just the one. I'll fix it after merging.