search

tnovau / react-circle-flags

:rocket: A React component with a collection of 300+ minimal circular SVG country flags. Wrapper of HatScripts/circle-flags
https://tnovau.github.io/react-circle-flags
MIT License
61 stars 8 forks source link

Name convention #3

Closed damianpumar closed 4 years ago

damianpumar commented 4 years ago

Hi mate! 🤙🏻 I found a variable name convention issue here, I think you have to change this variable name, because xx is not a country code valid. https://github.com/tnovau/react-circle-flags/blob/daf9675ea5ebdf480f28577511e0c0cbc96290da/src/index.js#L6

Cool! 🕶