search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

spec.containers[0].image: Invalid value: " " #103

Closed sirwalrus closed 4 years ago

sirwalrus commented 5 years ago

What happened:

Pod fails to deploy: ReplicaFailure True

FailedCreate Pod "openshift-acme-6884d74c97-786v5" is invalid: spec.containers[0].image: Invalid value: " ": must not have leading or trailing whitespace

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

oc new-project stage-letsencrypt oc create -fhttps://raw.githubusercontent.com/tnozicka/openshift-acme/master/deploy/letsencrypt-staging/cluster-wide/{clusterrole,serviceaccount,imagestream,deployment}.yaml oc adm policy add-cluster-role-to-user openshift-acme -z openshift-acme

Anything else we need to know?:

Tried this with the "live" configs, same problem.

Environment:

Client Version: version.Info{Major:"4", Minor:"1+", GitVersion:"v4.1.9-201907311355+45479a5-dirty", GitCommit:"45479a5", GitTreeState:"dirty", BuildDate:"2019-07-31T21:33:07Z", GoVersion:"go1.11.6", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.4+a8c5f5b", GitCommit:"a8c5f5b", GitTreeState:"clean", BuildDate:"2019-08-21T12:56:45Z", GoVersion:"go1.11.6", Compiler:"gc", Platform:"linux/amd64"}

@tnozicka

tnozicka commented 5 years ago

what is you openshift server version? (newer oc shows it correctly, I don't have a 4.x cluster running at this time but I think you can do it manually by oc get clusterversion modulo typos)

also the " " means the imagestream trigger didn't resolve - possibly just yet, maybe your registry is down - are other imagestreamtriggers working for you?

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 4 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 4 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/tnozicka/openshift-acme/issues/103#issuecomment-584115702): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.