search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

Fix readme #105

Closed jfchevrette closed 4 years ago

jfchevrette commented 4 years ago

What type of PR is this? /kind documentation

What this PR does / why we need it: This fixes a very severe bug in the README where a missing i in the word certificates may be causing confusion and uncertainty to the users

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: The added character has been very carefully chosen so that the resulting certificates word is both efficient and future-proof

Does this PR introduce a user-facing change?: I filed this PR mostly as a joke and I don't think I should extending this to the release-notes :-)

openshift-ci-robot commented 4 years ago

@jfchevrette: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

Welcome @jfchevrette! It looks like this is your first PR to tnozicka/openshift-acme 🎉

jfchevrette commented 4 years ago

/release-note-none

openshift-ci-robot commented 4 years ago

@jfchevrette: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-cluster-wide 18f767529966fd3d78c581b2a7f40703b1b02e8b link /test e2e-cluster-wide
ci/prow/e2e-single-namespace 18f767529966fd3d78c581b2a7f40703b1b02e8b link /test e2e-single-namespace

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jfchevrette, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tnozicka/openshift-acme/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 4 years ago

/override e2e-cluster-wide /override e2e-single-namesapce

openshift-ci-robot commented 4 years ago

@tnozicka: /override requires a failed status context to operate on. The following unknown contexts were given:

Only the following contexts were expected:

In response to [this](https://github.com/tnozicka/openshift-acme/pull/105#issuecomment-546301273): >/override e2e-cluster-wide >/override e2e-single-namesapce Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tnozicka commented 4 years ago

/override ci/prow/e2e-cluster-wide /override ci/prow/e2e-single-namespace

openshift-ci-robot commented 4 years ago

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-cluster-wide, ci/prow/e2e-single-namespace

In response to [this](https://github.com/tnozicka/openshift-acme/pull/105#issuecomment-546301412): >/override ci/prow/e2e-cluster-wide >/override ci/prow/e2e-single-namespace Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.