tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

must delete image stream before upgrading from v1 #119

Closed djdevin closed 3 years ago

djdevin commented 4 years ago

Upgrading from v1, I ran the cluster wide steps in the deployment guide.

The new pods failed. I checked the image stream and it was still using the old v1 images. I didn't catch it but it was some error about Unknown parameter --expose...something (sorry), so I figured the image was still out of date.

I deleted the imagestream and re ran all the deployment commands and everything worked because it brought in the new v2 image.

(Also, thanks for this project!)

oc v3.11.0+8de5c34 kubernetes v1.10.0+d4cacc0 features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://xxx:443 openshift v3.11.0+bdd37ad-314 kubernetes v1.11.0+d4cacc0

@tnozicka

tnozicka commented 4 years ago

yeah, that's expected. until we have an operator to manage our objects the deploy steps assume clean namespace - might worth to mention it explicitly there though

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/tnozicka/openshift-acme/issues/119#issuecomment-751892463): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.