search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

Allow configuring default cert RSA key size #124

Closed tnozicka closed 4 years ago

tnozicka commented 4 years ago

What type of PR is this? /kind feature

What this PR does / why we need it: Some users want to use 2048 keys for performance or compatibility reasons. This allows having a choice.

Which issue(s) this PR fixes: Fixes https://github.com/tnozicka/openshift-acme/issues/120

Does this PR introduce a user-facing change?:

--cert-default-rsa-key-bit-size flag allows choosing the default RSA key bit size
openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tnozicka/openshift-acme/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 4 years ago

/retest

vincenzodnp commented 4 years ago

Does it use an k8s annotation? what is the name of the annotation? Thanks!

tnozicka commented 4 years ago

no, this is adding cluster-wide flag instead https://github.com/tnozicka/openshift-acme/pull/124/files#diff-7de04b860f288545dc225de20a47af16R137

vincenzodnp commented 4 years ago

Hello @tnozicka Thanks for the PR. One question. Once --cert-default-rsa-key-bit-size is set at the cluster level (acme-controller), is it possible to override per single route? I mean if it possible, with an annotation or something, to ask acme-controller to issue certs with a key size different than the default one. Thanks VIncenzo

tnozicka commented 4 years ago

It is not possible to override it currently. (Wasn't possible before either.)