search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

Add static AcmeTemporaryLabel to pods #125

Closed hufon closed 3 years ago

hufon commented 4 years ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it: I need to implement networkpolicies on my project. Exposer pods doesn't have static labels to match thems

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

hufon commented 4 years ago

I've added AcmeExposerPodLabel instead

hufon commented 4 years ago

Is there a problem with this ?

tnozicka commented 4 years ago

can you fix the commits? otherwise this lgtm

hufon commented 4 years ago

fix the commits?

tnozicka commented 4 years ago

fix the commits?

there are 3 commits in this PR https://github.com/tnozicka/openshift-acme/pull/125/commits named:

tnozicka commented 4 years ago

/ok-to-test

tnozicka commented 4 years ago

/ok-to-test

openshift-ci-robot commented 4 years ago

@hufon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-single-namespace ec6ac5d6241019f727ec271c838422ecd58a74b1 link /test e2e-single-namespace
ci/prow/e2e-specific-namespaces ec6ac5d6241019f727ec271c838422ecd58a74b1 link /test e2e-specific-namespaces
ci/prow/e2e-cluster-wide ec6ac5d6241019f727ec271c838422ecd58a74b1 link /test e2e-cluster-wide

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/tnozicka/openshift-acme/pull/125#issuecomment-752331116): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.