search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

Fix queue.Add panic #136

Closed tnozicka closed 4 years ago

tnozicka commented 4 years ago

What type of PR is this? /kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #131

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/priority critical-important

openshift-ci-robot commented 4 years ago

@tnozicka: The label(s) priority/critical-important cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/tnozicka/openshift-acme/pull/136): >**What type of PR is this?** >/kind bug > >**What this PR does / why we need it**: > >**Which issue(s) this PR fixes**: >Fixes #131 > >**Special notes for your reviewer**: > >**Does this PR introduce a user-facing change?**: >```release-note >NONE >``` > >/priority critical-important > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tnozicka/openshift-acme/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 4 years ago

aws flake /retest