Closed madmatah closed 3 years ago
Welcome @madmatah! It looks like this is your first PR to tnozicka/openshift-acme 🎉
Hi @madmatah. Thanks for your PR.
I'm waiting for a tnozicka member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: madmatah, tnozicka
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
/lgtm
What type of PR is this?
/kind bug
What this PR does / why we need it:
I think there is a problem with the
acme.openshift.io/priority
annotation. The sorting function seems to compare each CertIssuer's priority to itself.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: