Fix static name for exposers

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)

Apache License 2.0

319 stars 116 forks source link

Fix static name for exposers #146

Closed tnozicka closed 3 years ago

tnozicka commented 3 years ago

What type of PR is this? /kind bug

What this PR does / why we need it: https://github.com/tnozicka/openshift-acme/issues/140#issuecomment-738735037 noted a collision on the current id.

Which issue(s) this PR fixes: Fixes https://github.com/tnozicka/openshift-acme/issues/140#issuecomment-738735037

Does this PR introduce a user-facing change?:

Fixes a race where the controller would create a duplicate exposer Route which got stuck on `HostAlreadyClaimed` error.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tnozicka/openshift-acme/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tnozicka commented 3 years ago

infra/installer /retest

tnozicka commented 3 years ago

/retest