search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

Set proper owner reference api version #156

Closed lukeelten closed 3 years ago

lukeelten commented 3 years ago

What type of PR is this? /kind bug

What this PR does / why we need it: The resource created by the controller do not get cleaned after the cert has been issued and the route is deleted.

Which issue(s) this PR fixes:

Fixes #149

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
openshift-ci-robot commented 3 years ago

Welcome @lukeelten! It looks like this is your first PR to tnozicka/openshift-acme 🎉

openshift-ci-robot commented 3 years ago

Hi @lukeelten. Thanks for your PR.

I'm waiting for a tnozicka member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lukeelten commented 3 years ago

/ok-to-test

/assign @tnozicka

openshift-ci-robot commented 3 years ago

@lukeelten: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/tnozicka/openshift-acme/pull/156#issuecomment-816196738): >/ok-to-test > >/assign @tnozicka Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tnozicka commented 3 years ago

/ok-to-test

tnozicka commented 3 years ago

/approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lukeelten, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tnozicka/openshift-acme/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 3 years ago

/retest

tnozicka commented 3 years ago

looks like openshift ci has changed log artifacts location so unit job needs https://github.com/openshift/release/pull/17662

tnozicka commented 3 years ago

https://github.com/openshift/release/pull/17662 merged /retest