Open alesuiss opened 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alesuiss
To complete the pull request process, please assign tnozicka after the PR has been reviewed.
You can assign the PR to them by writing /assign @tnozicka
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Hi @alesuiss. Thanks for your PR.
I'm waiting for a tnozicka member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, when an order is
ready
,openshift-acme
calls the go ACME library to submit the CSR and obtain the certificate. The library waits until the certificate is returned. Therefore, if the ACME server takes too long, the library will timeout and no certificate is configured. But the ACME server still creates the certificate and switches the order tovalid
. However,openshift-acme
does nothing with that, and the certificate is never pushed to theRoute
.This PR extends the logic to allow obtaining the certificate in
valid
state.Which issue(s) this PR fixes:
The ability to obtain certificates asynchronously, fixing problems with ACME servers that take longer than the ACME library timeout to generate certificates.
Special notes for your reviewer:
Please excuse the crudity of this PR, I didn't have time to build it do scale or to paint it, as this was an emergency fix for our systems. There is some duplicated code and I didn't clean up the comments.
Does this PR introduce a user-facing change?:
No