search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

implement router sharding support #69

Closed wilderbridge closed 4 years ago

wilderbridge commented 6 years ago

Fixes #45 by making it possible to configure labels to challenge URL

wilderbridge commented 6 years ago

Seems to me that the build is triggered for go version go1.7.4 linux/amd64 which I guess is unwanted. By fixing the CI it should show green light.

Same thing happening with current open pull requests.

aramalipoor commented 6 years ago

Any updates on this?

foosinn commented 5 years ago

i would also like to see this merged. is there anything we can help with?

openshift-merge-robot commented 5 years ago

/retest

openshift-merge-robot commented 5 years ago

/retest

tnozicka commented 5 years ago

/ok-to-test /retest

openshift-bot commented 5 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

wilderbridge commented 5 years ago

/retest

tnozicka commented 5 years ago 
Conflicting files
pkg/cmd/cmd.go

this conflict needs to be solved first, or the test keep failing

openshift-bot commented 5 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

LorbusChris commented 5 years ago

@tanskann would you mind rebasing? /remove-lifecycle rotten

wilderbridge commented 5 years ago

@LorbusChris I'll try to find some time this week

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tanskann To complete the pull request process, please assign tnozicka You can assign the PR to them by writing /assign @tnozicka in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tnozicka/openshift-acme/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 years ago

@tanskann: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e 283396a2a6780232977ae96e452b78410a325dbb link /test e2e
ci/prow/e2e-single-namespace 7d30ae0d91db1c4b041de0733a19289f6e0d8969 link /test e2e-single-namespace

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 5 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

LorbusChris commented 4 years ago

/remove-lifecycle rotten

tnozicka commented 4 years ago

v2 rewrite in https://github.com/tnozicka/openshift-acme/pull/92 deep copies the original route so it gets any labels set on the original route - I think that should cover the use case, right?

We also don't get successful CI runs until that's merged as LE disabled staging and now also live v1 registrations.

As I think https://github.com/tnozicka/openshift-acme/pull/92 fixes the issue and also outdated the code modified here, I'll close this PR.