search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

Allow email address for account registration to be set in environment #84

Closed seandilda closed 4 years ago

seandilda commented 5 years ago

With this change, setting the OPENSHIFT_ACME_EMAILADDR environment variable will cause the email address to be used when creating a new ACME account.

This is a stop-gap fix for https://github.com/tnozicka/openshift-acme/issues/26 until the more complete solution is ready.

openshift-ci-robot commented 5 years ago

Hi @seandilda. Thanks for your PR.

I'm waiting for a tnozicka or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tnozicka commented 5 years ago

/ok-to-test

openshift-bot commented 5 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 5 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seandilda To complete the pull request process, please assign tnozicka You can assign the PR to them by writing /assign @tnozicka in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tnozicka/openshift-acme/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
seandilda commented 5 years ago

/remove-lifecycle rotten /assign @tnozicka

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

seandilda commented 4 years ago

/remove-lifecycle rotten

@tnozicka Any update on this?

tnozicka commented 4 years ago

I agree we want setting the email address, generally to sync whatever is in that secret (annotations) into ACME account updates. There should be a dedicated control loop handling account updates. While we don't have it yet, any new CI runs are kinda borked on LE disabling v1 registrations live+staging so I have to deliver v2 rewrite first in https://github.com/tnozicka/openshift-acme/pull/92 which will also make this outdated. I'll see if I can squeeze the account updates into the initial version as dedicated control would make the account handling cleaner, or add it in next iteration as delivering v2 is time sensitive.

tnozicka commented 4 years ago

The code is outdated by the v2 rewrite (these pieces are no longer there). Let's iterate when v2 merges, the proposed functionality is still desired.