search

tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

Rename the annotation to a different namespace #89

Closed Exordian closed 5 years ago

Exordian commented 5 years ago

Currently you're using kubernetes.io/tls-acme in your project. kubernetes.io/ is/should already reserved for k8s core components [1]. If k8s ever implements an acme extension itself the nameclash could be bad. I'd suggest renaming it.

[1] https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#syntax-and-character-set

tnozicka commented 5 years ago

Technically yes. The key here is that other projects in this area use the same annotation so we are compatible and interchangeable.

I'd not worry too much about the technicality here as kube is unlikely to claim it and we can migrate if that were to come. The compatibility wins for me. We could probably claim the annotation in kube as a shared point for such extensions but nobody has gone through the effort to do it.

openshift-bot commented 5 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 5 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 5 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 5 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/tnozicka/openshift-acme/issues/89#issuecomment-522368433): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.