tnozicka / openshift-acme

ACME Controller for OpenShift and Kubernetes Cluster. (Supports e.g. Let's Encrypt)
Apache License 2.0
319 stars 116 forks source link

Migrate manifests from legacy to API groups #97

Closed tnozicka closed 5 years ago

tnozicka commented 5 years ago

/kind bug

What this PR does / why we need it: OpenShift 4.1 droped legacy API. (Controller was using/requiring API groups just the manifests were stale.)

Which issue(s) this PR fixes: Fixes https://github.com/tnozicka/openshift-acme/issues/93

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tnozicka/openshift-acme/blob/master/OWNERS)~~ [tnozicka] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 years ago

New changes are detected. LGTM label has been removed.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.