tnt / ansible-gpg-import-module

Ansible module for managing GPG-keys
32 stars 9 forks source link

Weird confusion between key_type, key_file, key_id in documentation ? #16

Open w2ak opened 6 years ago

w2ak commented 6 years ago

Here is a doubt I had while reading your description. It seems easy to change and if I am right I will gladly submit a pull request, I just wanted to be sure that I understood well.

https://github.com/tnt/ansible-gpg-import-module/blob/master/gpg_import.py#L35

key_type is either private or public. I guess it corresponds to what I only ever called secret and public. If I did not misunderstand, I think there are two mistakes in the descriptions of the key_file and key_id.

https://github.com/tnt/ansible-gpg-import-module/blob/master/gpg_import.py#L21

key_id says that it is only for private/secret keys, which is weird because you cannot import private keys from key servers

https://github.com/tnt/ansible-gpg-import-module/blob/master/gpg_import.py#L27

key_file says that it is only for public keys, which is weird because your examples show how to use it for private keys and I think that is also what I read in the code.