search

tnt / ansible-gpg-import-module

Ansible module for managing GPG-keys
32 stars 9 forks source link

Submit module for inclusion in Ansible #3

Open conorsch opened 9 years ago

conorsch commented 9 years ago

Great work, thanks for sharing. Please consider submitting the gpg_import module directly to Ansible, via the Extra Modules repository: https://github.com/ansible/ansible-modules-extras. Then folks would have access to it without needing to clone your repo and copy the file around between projects.

You could also distribute it via Ansible Galaxy by packaging the library within a role, as seen here: https://github.com/yaegashi/ansible-role-blockinfile That's a bit of a hack, and folks using it would still need to reference the role in every play they intend to use the module, but it's probably less work than submitting for inclusion.

tnt commented 9 years ago

Thank you.

I suppose there would be needed at least the addition of some tests to get included to Ansible Extras and I'm currently too busy for that. Since I've fixed the license issue, if you like...

conorsch commented 8 years ago

Since I've fixed the license issue, if you like...

Thanks for that. I missed this on recent trips back to the repo, because I wasn't looking inside the module file itself. Generous of you. I'll refresh myself on how the module works (getting irritated with repetitious gpg --import tasks again, which is why I'm back here) and see it we can't submit it for inclusion.

tedder commented 8 years ago

The problem with submitting to -extras is a really long cycle for fixing problems/releasing new features.

Just about to pull it down and improve it on file-based keys (hopefully).

conorsch commented 8 years ago

@tedder Glad to hear it. I've just pulled the module down and added it to a local site config so I can start using it day-to-day, which should help identifying fixes. If you end up submitting it and need a review, feel free to tag me.

tedder commented 8 years ago

Okay, I'll tag you. I'm doing some iteration on the file-based key things right now. It's a bit of brain surgery but it'll be a great new feature.

noaho commented 7 years ago

+1 on Ansible Galaxy being useful. I think you just need to add some metadata files before it is ready for people to point at your github.