search

tntim96 / JSCover

JSCover is a JavaScript Code Coverage Tool that measures line, branch and function coverage
GNU General Public License v2.0
399 stars 84 forks source link

Add support for jasmine pending tests #230

Closed felquis closed 2 years ago

felquis commented 8 years ago

Also add support of jasmine from 2.0.x, 2.3.x, 2.4.x I couldn't test with jasmine 2.2.x cause it doens't work

I made a course on TutsPlus, and it uses JSCover, but the course is outdated, cause jasmine source has changed a little, and what works on the course, doesn't work with the current version of Jasmine2 and JSCover.

This patch fixes JSCover to work with all 2.x of jasmine, except 2.2.x

It also doesn't totally fail when there's pending tests image

Hope it help, all my tests is located in https://github.com/felquis/jasmine-jscover

tntim96 commented 8 years ago

Thanks, I'll take a look

tntim96 commented 8 years ago

The original code was sourced from https://github.com/ariya/phantomjs/blob/master/examples/run-jasmine2.js, so it is best fixed there. I noticed I didn't create a PR previously for the Jasmine 2.4.1 changes I've made, so have done so here https://github.com/ariya/phantomjs/pull/14281. You could perhaps branch from my branch. If the changes are accepted by PhantomJS project, I'll update from there (unless there's no progress after a reasonable time).

felquis commented 2 years ago

Closing it since we have moved on. Thank you for your time back then.