search

tnychn / mpv-discord

🎈 A cross-platform Discord Rich Presence integration for mpv with no external dependencies.
MIT License
172 stars 14 forks source link

Disable presence when paused/idle options #11

Closed Reinbowsaur closed 3 years ago

Reinbowsaur commented 3 years ago

Could be different too something like, if paused for (custom timer) then disable presence until state play state changes. Setting timer to 0, would instantly disable presense on pause.

If you were able to implement this feature, I'd be downloading changing to using your version of RPC in a heartbeat. I don't know why so many people like sharing useless details that they are paused or left their player open.

Cheers, hope you consider this feature.

tnychn commented 3 years ago

I implemented your suggestion but I don't think allowing users to instantly disable the presense on pause by setting a 0 threshold is a good idea. If the user pauses the player frequently, it might potentially break the program as there would be too many dis/reconnections. I don't think the client could handle it.

The current implementation is that the presence will only hide when paused if the autohide_threshold option in the config is > 0 to prevent users from specifying a 0 threshold. Setting a 0 threshold turns auto-hide off.

Reinbowsaur commented 3 years ago

One week of use, absolutely no problems. Loved the response time for this additon!

A note, I did have some trouble with the using the installer script (windows 10) (it immediately exited upon entering path leaving no evidence of any actions performed either no files nothing, i might have being inputting my location wrong but I did try a few ways/running as admin ect) so I ended up moving files to appropriate places manually to get it working instead.

tnychn commented 3 years ago

Thanks! I will check out the Windows installer script again.