search

tnychn / mpv-discord

🎈 A cross-platform Discord Rich Presence integration for mpv with no external dependencies.
MIT License
172 stars 14 forks source link

added static ipc support and configurabe dynamic ipc support #4

Closed JoschuaL closed 3 years ago

JoschuaL commented 3 years ago

Added support for configuring weather a dynamic or static ipc socket should be used, with the abilitu to configure where the dynamic ipc socket should be created. It would potentially also make sense to enable configuring the path of the static ipc socket, though that seems less usefull to me since that is typically set to /tmp/mpvsocket.

I tested this on linux, in combination with SVP, and as long as both are configured the same way (either both use /tmp/mpvsocket or both use /tmp/mpvSockets/$PID), they work flawlessly with each other.

I did not test on macos or windows, as I currently dont have these OS available to me.

macos should work out of the box, though windows might be tricky.

tnychn commented 3 years ago

I'm gonna work on this myself to implement your suggestions. Thanks anyway for your ideas!

tnychn commented 3 years ago

Closing this pull request as this has been implemeted at 1fd2498. Also check out the latest v1.3.1 release.