search

toadie2k / NIArms

45 stars 44 forks source link

NIArms open bolt weapons are incompatible with ace cookoff #174

Open BorderKeeper opened 2 years ago

BorderKeeper commented 2 years ago

Open bolt weapons in NIArms are wrongly set as closed bolt causing them to cook off in ACE even though they should not

Drofseh commented 2 years ago

The root cause of this is that many (all?) NI Arms machine guns use Rifle_Base_F as their parent class, while vanilla machine guns and many other mod machine guns use Rifle_Long_Base_F for their parent class.

In ACE3's Overheating addon Rifle_Long_Base_F are assumed to be open bolt be default, while Rifle_Base_F are assumed to be closed bolt by default, through Rifle. https://github.com/acemod/ACE3/blob/master/addons/overheating/CfgWeapons.hpp

The best fix imo, would be to change NI Arms to follow the same inheritence as is typical for vanilla, and use Rifle_Long_Base_F as the parent for all machine gun classes, leaving Rifle_Base_F for rifles.

Alternatively, each weapon base class can be set individually to open or closed bolt with ace_overheating_closedBolt, https://ace3mod.com/wiki/framework/overheating-framework.html#14-cook-off