Failed examples:
rspec ./spec/lib/railsstrap/form_errors_helper_spec.rb:41 # Railsstrap::FormErrorsHelper error[:base] is a string should render base error on :base key
rspec ./spec/lib/railsstrap/form_errors_helper_spec.rb:57 # Railsstrap::FormErrorsHelper when there is only one error on base should render base error on :base key
rspec ./spec/lib/railsstrap/form_errors_helper_spec.rb:73 # Railsstrap::FormErrorsHelper when there is only one error on title should render base errors join with comma
rspec ./spec/lib/railsstrap/form_errors_helper_spec.rb:90 # Railsstrap::FormErrorsHelper when there is more than one error on title should render base errors join with comma
rspec ./spec/lib/railsstrap/form_errors_helper_spec.rb:119 # Railsstrap::FormErrorsHelper when :error_class option is passed should render with passed error class
rspec ./spec/lib/railsstrap/form_errors_helper_spec.rb:136 # Railsstrap::FormErrorsHelper when :error_class option is passed should render with passed error class
rspec ./spec/lib/railsstrap/navbar_helper_spec.rb:132 # Railsstrap::NavbarHelper drop_down should output <li class='dropdown'><a class='dropdown-toggle'></a></li>
rspec ./spec/lib/railsstrap/navbar_helper_spec.rb:142 # Railsstrap::NavbarHelper drop_down_with_submenu should output a three level menu item
rspec ./spec/lib/railsstrap/navbar_helper_spec.rb:185 # Railsstrap::NavbarHelper menu_text should be able to cope with a block too
rspec ./spec/lib/railsstrap/navbar_helper_spec.rb:193 # Railsstrap::NavbarHelper rendering forms ok should not escape anything unexpectedly
rspec ./spec/lib/railsstrap/navbar_helper_spec.rb:205 # Railsstrap::NavbarHelper default navbar renders a navbar
I'll fix them as soon as possible unless someone beats me to it. Just for clarity this release branch will only contain updated versions of Bootstrap, Fontawesome, and some minor improvements in Railsstrap css. It does not contain anything from feature/refactor branch.
Coverage remained the same at 98.06% when pulling 596e20fd90e179f7fdb867ad7b0e258b65ffdd85 on release/3.3.4 into 0899010e9fcce46f54c7569fa920e1f994697976 on develop.
Coverage remained the same at 98.06% when pulling 596e20fd90e179f7fdb867ad7b0e258b65ffdd85 on release/3.3.4 into 0899010e9fcce46f54c7569fa920e1f994697976 on develop.
Coverage increased (+1.39%) to 99.45% when pulling 50d4ff4bf46fd3bd1867a81812f8f99d63a0cac8 on release/3.3.4 into 0899010e9fcce46f54c7569fa920e1f994697976 on develop.
I'm getting this right now:
I'll fix them as soon as possible unless someone beats me to it. Just for clarity this release branch will only contain updated versions of Bootstrap, Fontawesome, and some minor improvements in Railsstrap css. It does not contain anything from feature/refactor branch.