toandaominh1997 / EfficientDet.Pytorch

Implementation EfficientDet: Scalable and Efficient Object Detection in PyTorch
MIT License
1.44k stars 305 forks source link

No Depth-wise convolution for BiFPN? #120

Open yaoliUoA opened 4 years ago

yaoliUoA commented 4 years ago

The EfficientDet paper uses depth-wise convolution of BiFPN, however, in this implementation, clearly depth-wise convolution is not used (in module.py).

`conv_cfg = { 'Conv': nn.Conv2d, 'ConvWS': ConvWS2d,

TODO: octave conv

} ' ' def build_convlayer(cfg, *args, **kwargs): """ Build convolution layer Args: cfg (None or dict): cfg should contain: type (str): identify conv layer type. layer args: args needed to instantiate a conv layer. Returns: layer (nn.Module): created conv layer """ if cfg is None: cfg = dict(type='Conv') else: assert isinstance(cfg, dict) and 'type' in cfg cfg_ = cfg.copy()

layer_type = cfg_.pop('type')
if layer_type not in conv_cfg:
    raise KeyError('Unrecognized norm type {}'.format(layer_type))
else:
    conv_layer = conv_cfg[layer_type]

layer = conv_layer(*args, **kwargs, **cfg_)

return layer` 
jiangnanLZP commented 4 years ago

i have the same issue