search

toarnold / Coremoran.BluePrism.DynamicLinq

MIT License
4 stars 1 forks source link

Dynamic Linq - Concat #1

Open GeoffHirstBP opened 2 years ago

GeoffHirstBP commented 2 years ago

Tobias,

Thank you for using Blue Prism and taking the time to create assets for our Digital Exchange.

I am reviewing your assets prior to upload on the Digital Exchange. I am experiencing a problem with the concat main page of your Dynamic Linq testsuite.

The exception is:

Internal : Unexpected error Array cannot be null. Parameter name: bytes

I have tried to make the actions following concat work but I am getting the same exception.

Can you advise?

regards Geoff Hirst Sr DX Engineer - Blue Prism.

toarnold commented 2 years ago

Hi Goeff,

your are right. There a five test missing (Concat, Distinct, Esxcept, Intersect, Union) in the bprelease package, but there are included in the repository. As a workaorund you can clone the repository an import the missing tests. I will correct the relase asset this evening

Tobias

GeoffHirstBP commented 2 years ago

Hi Tobias,

I have now rectified the test suite to include those that were missing and now I have the test suite pretty much working fine with a single error on one of the join tests. The inner empty test is reporting a LeftKeySelector empty.

I will assume you will address this and I will advise my colleagues that your assets are acceptable for release to the Digital Exchange. My only suggestion is on the readme documentation, it would be useful to have the same installation and configuration details for all assets.

Thank you for using Blue Prism and thank you for creating assets for our Digital Exchange.

regards Geoff Hirst Sr DX Engineer - Blue Prism

toarnold commented 2 years ago

Hi Goeff,

The release asset has been updated. The join tests are now fixed so far.

For the future I'll try to write a more detailed installation guide which will be sufficient for all assets.

Tobias