search

toast-tk / toast-tk-engine

The core automation framework for your acceptance tests
http://toast-tk.io
Other
12 stars 5 forks source link

Embed jdk8 & chromedriver in toast-web-agent #127

Closed skokaina closed 7 years ago

skokaina commented 7 years ago

The idea is to have chromedriver.exe included with the msi installer. The path to chrome driver will have to be set by default to the destination directory. Nathan, do you think we could include this one for next week release ?

NathCoco commented 7 years ago

Yes it is possible.

Which version of the chromedriver do you want ? Is the 2.25 fine ? (https://sites.google.com/a/chromium.org/chromedriver/downloads)

Which destination directory do you want ? The same as the AgentLancher.exe ? We have to add to the agent the default directory of the chromedriver, don't you think ?

skokaina commented 7 years ago

Let's go with 2.24, since we haven't tested the agent againt 2.25 yet in $user.home/.toast directory is perfect, if we can include a jdk8 in the directory that would be perfect since some users might not have java installed on their machine. Doing this, you'd need to change the command line to run the agent through for the AgentLauncher.exe (and a u :))

NathCoco commented 7 years ago

Ready to be pushed on master

skokaina commented 7 years ago

Please create a pull request

NathCoco commented 7 years ago

Commited on master