search

toastdotdev / toast

The best place to stack your JAM. Toast is a Jamstack framework
153 stars 13 forks source link

0/max int sources compiled #11

Closed ChristopherBiscardi closed 3 years ago

ChristopherBiscardi commented 3 years ago

when compiling sources, the progress is set to 0/MAX_INT. That is both incorrect and confusing, although it doesn't affect actual behavior.

The offending progress bar is this one: https://github.com/toastdotdev/toast/blob/bdcf61d18d36ca64fef496b9f117f1bada6a58fe/toast/src/incremental.rs#L186-L220 and it should be changed to either be like pb1 or if we have the total list we should display 0/N instead of 0/MAX_INT

shrirambalaji commented 3 years ago

@ChristopherBiscardi I'll take a stab at this :)

lannonbr commented 3 years ago

This was resolved in 0.3.14 for me