toastdotdev / toast

The best place to stack your JAM. Toast is a Jamstack framework
153 stars 13 forks source link

npm install breaks on node 12 without any warning #14

Closed pantharshit00 closed 3 years ago

pantharshit00 commented 3 years ago

image

I am aware that this project only supports node 14 but it should display a warning instead of failing with this vague error message :)

ChristopherBiscardi commented 3 years ago

Issue was not closed by #19 (which applied to the development repo, not to the end-user installation)

ChristopherBiscardi commented 3 years ago

@pantharshit00 is this still an issue on 0.3.12 for you? I think 0.3.4 might have just been an old release before the engines field was added

image

ChristopherBiscardi commented 3 years ago

ah, my error is if you use yarn, which respects engines. npm apparently does not respect engines

ChristopherBiscardi commented 3 years ago

We should investigate dropping the node requirement to v12 since many esm features have been back-ported.

That said, npm v7 fixes this, so I'm going to close the issue without action on our side.