search

toastdotdev / toast

The best place to stack your JAM. Toast is a Jamstack framework
153 stars 13 forks source link

updating package.json to require Node v14 or greater #19

Closed joshfinnie closed 3 years ago

joshfinnie commented 3 years ago

This updates the package.json to require Node v14 or greater. This should fix #14 for you.

If user attempts to run npm install with these settings, you get the following error:

npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for toast-workspace@1.0.0: wanted: {"node":">=14.0.0"} (current: {"node":"12.18.3","npm":"6.14.8"})
npm ERR! notsup Not compatible with your version of node/npm: toast-workspace@1.0.0
npm ERR! notsup Not compatible with your version of node/npm: toast-workspace@1.0.0
npm ERR! notsup Required: {"node":">=14.0.0"}
npm ERR! notsup Actual:   {"npm":"6.14.8","node":"12.18.3"}
ChristopherBiscardi commented 3 years ago

This only applies to development of the core packages (because it's in the root workspace), while #14 applies to users using the toast package. I'm still happy to accept this PR because I think it's useful guardrails for contributors, but I'll re-open #14 after merging.