search

toastdotdev / toast

The best place to stack your JAM. Toast is a Jamstack framework
153 stars 13 forks source link

missing output in CI #34

Open jbolda opened 3 years ago

jbolda commented 3 years ago

I've noted this in Github Actions, but I am assuming it applies to any of the CI systems. I would expect to see the number of pages generated for instance.

example: https://github.com/toastdotdev/toast/pull/33/checks?check_run_id=1230126634#step:13:14

ChristopherBiscardi commented 3 years ago

yeah, we currently use progress bars to display activity to users, and these progress bars are not shown in CI. We should count stuff up and display it at the end of the command regardless I think. Probably an optional dump to a file at some point in the future.

jlengstorf commented 3 years ago

I think most CI will set process.env.CI, so maybe a conditional check for that and log additional details?

ChristopherBiscardi commented 3 years ago

I think it's valid to print out some Results struct we maintain over the process with metadata and whatnot by default. the progress bars are progress indicators. Probably don't need to vary behavior based on CI for this