search

toastdotdev / toast

The best place to stack your JAM. Toast is a Jamstack framework
153 stars 13 forks source link

exit code incorrectly set for some errors #35

Closed jbolda closed 3 years ago

jbolda commented 3 years ago

There are some errors that do not have the exit code correctly set. Running locally this isn't as apparent, but when run within CI it will look like a green build when in reality there is an error.

example: https://github.com/toastdotdev/toast/pull/33/checks?check_run_id=1230126662#step:13:22

ChristopherBiscardi commented 3 years ago

this is due to the fact that node stderr is not currently treated as an error and needs to be. We also have to strip the warning that is currently output there out and also make sure the text output is output above the progress bars so that stderr from node doesn't fight with the progress bars (also on stderr)

ChristopherBiscardi commented 3 years ago

this should be fixed as of #38