toastdotdev / toast

The best place to stack your JAM. Toast is a Jamstack framework
153 stars 13 forks source link

`npm install` error output (doesn't break anything) #61

Open jlengstorf opened 3 years ago

jlengstorf commented 3 years ago

I've been working between computers, and it seems like whenever my package-lock.json changes and I run npm i, I get this error from Toast

❯ npm i

> toast@0.3.30 preuninstall /Users/jlengstorf/github/learnwithjason/learnwithjason.dev/node_modules/toast
> node ./binary-management/uninstall.js

file:///Users/jlengstorf/github/learnwithjason/learnwithjason.dev/node_modules/toast/binary-management/binary.js:96
      `${this.name ? this.name : "Your package"} has been uninstalled`
              ^

TypeError: Cannot read property 'name' of undefined
    at uninstall (file:///Users/jlengstorf/github/learnwithjason/learnwithjason.dev/node_modules/toast/binary-management/binary.js:96:15)
    at file:///Users/jlengstorf/github/learnwithjason/learnwithjason.dev/node_modules/toast/binary-management/uninstall.js:5:1
    at ModuleJob.run (internal/modules/esm/module_job.js:146:23)
    at async Loader.import (internal/modules/esm/loader.js:165:24)
    at async Object.loadESM (internal/process/esm_loader.js:68:5)
npm WARN lifecycle toast@0.3.30~preuninstall: continuing anyway toast@0.3.30 preuninstall: `node ./binary-management/uninstall.js`
npm WARN lifecycle Exit status 1

this doesn't cause any problems as far as I can tell, but I'm not sure if this is preventing Toast from doing something it needs?

ChristopherBiscardi commented 3 years ago

oh this is because no one ever runs "npm uninstall ", so it doesn't get run often and we simply broke the uninstall (which just leaves the binary on the filesystem) We can probably just delete this file tbh.