search

toasterofbread / spmp

A YouTube Music client with a focus on customisation of colours and song metadata. Built with Compose Multiplatform for Android and desktop.
GNU General Public License v3.0
1.02k stars 42 forks source link

KuGou lyrics provider not working #104

Closed ElizabethWega closed 1 year ago

ElizabethWega commented 1 year ago

Android version: 13 App version: 0.1.3 Issue description: When I set KuGou as a default lyrics provider and press an assigned button to fetch the lyrics, all I get is a Loading lyrics text accompanied with a loading bar, which means no lyrics actually appearing on the screen. Once I change the default provider to PetitLyrics and use the assigned buttons to look up the lyrics in English via KuGou (I tried using PetitLyrics and it just doesn't work for me since I keep getting irrelevant results), I'm met with the following error: java.lang.RuntimeException: Lyrics not loaded. I am certain that the lyrics do exist on KuGou, for I requested the lyrics (for the same song; Fluorescent by MDSN) in two different apps using KuGou provider (SpMp and ViMusic). I have no clue if this is an app's or provider's fault but whatever the case any troubleshooting is greatly appreciated. Thanks in advance!

toasterofbread commented 1 year ago

Yeah, I've noticed this issue as well. Will fix soon.

toasterofbread commented 1 year ago

Strange, it seems some lyrics on Kugou (including for the song you mentioned) can't be downloaded with the method I'm using. Lyrics do appear in the search results, but trying to download the lyrics using the ID that Kugou provides leads to an empty response.

I'm using ViMusic as the reference for implementing Kugou but it doesn't seem to include a working method. I tried loading the lyrics for the same song using ViMusic and it didn't work there either. Can you confirm that ViMusic is still able to load lyrics for Fluorescent by MDSN?

ElizabethWega commented 1 year ago

Strange, it seems some lyrics on Kugou (including for the song you mentioned) can't be downloaded with the method I'm using. Lyrics do appear in the search results, but trying to download the lyrics using the ID that Kugou provides leads to an empty response.

I'm using ViMusic as the reference for implementing Kugou but it doesn't seem to include a working method. I tried loading the lyrics for the same song using ViMusic and it didn't work there either. Can you confirm that ViMusic is still able to load lyrics for Fluorescent by MDSN?

Yes, it shows unsynchronized lyrics. Maybe that's the issue? Synchronized/unsynchronized lyrics?

toasterofbread commented 1 year ago

I'm using the latest ViMusic and it doesn't load either type. Is this the exact song you're using? https://music.youtube.com/watch?v=BOgqXFWqKb8

ElizabethWega commented 1 year ago

I'm using the latest ViMusic and it doesn't load either type. Is this the exact song you're using? https://music.youtube.com/watch?v=BOgqXFWqKb8

This one: https://music.youtube.com/watch?v=Zo5pu7w1cg8

toasterofbread commented 1 year ago

Thanks. I've figured out what the issue is now, ViMusic only uses Kugou for synchronized lyrics. It uses YouTube Music for unsynchronised lyrics (and I think YouTube Music uses MusixMatch). I'll implement a way to view the lyrics from YouTube in SpMp as well.

ElizabethWega commented 1 year ago

Thanks. I've figured out what the issue is now, ViMusic only uses Kugou for synchronized lyrics. It uses YouTube Music for unsynchronised lyrics (and I think YouTube Music uses MusixMatch). I'll implement a way to view the lyrics from YouTube in SpMp as well.

Oh wow! I did not know that! Thank you! Looking forward to the new update 🙂

toasterofbread commented 1 year ago

Added YouTube Music as a lyrics source. Will be in the next update :+1: