toasterofbread / spmp

A YouTube Music client with a focus on customisation of colours and song metadata. Built with Compose Multiplatform for Android and desktop.
GNU General Public License v3.0
1k stars 42 forks source link

Can we fetch songs from the device #333

Closed Raghucharan16 closed 1 month ago

Raghucharan16 commented 2 months ago

I run into poor network all the time so it is preferable if app takes permission from local device and is allowed to play songs without internet connection (offline). (You gave an option to download to a custom path right that is very cool). And Thanks for this amazing work.

toasterofbread commented 2 months ago

SpMp already supports downloading songs for offline playback. Could you be more specific about what it is you'd want added/changed?

Raghucharan16 commented 2 months ago

Yes, what I meant to say is, it would be a good feature if the app asks permission for storage & media and can able play songs from device. As of now, it won't take any permissions so, as we can download the songs to any folder, if it can access the whole device, then it can fetch all the media right? And can also play songs even when it doesn't have internet. (Ofcourse that is there right now but I'm specific about songs on the device) And also from last 2 days, app is some what crashing. Don't know why? It first says, spmp is not responding (wait or close pop up) and then it will close suddenly. I don't know how to reproduce this because it is happening in the middle of searching a song or trying to play a searched song. Other than that app is so cool and thanks this amazing work. Screenshot_20240711-103019

toasterofbread commented 1 month ago

I'm still not entirely sure what you're asking. Setting the library directory to a location on internal storage should allow you to include external media (although this feature is somewhat half-baked).

If you're experiencing crashes, please create a new issue after capturing the relevant logs using logcat or an app like this one.

Raghucharan16 commented 1 month ago

I'm not sure how to put the requirement here, for me app should ask permission to read all storage files and then able to play on device media [songs]. even in the 0.4 release i guess it is not there.

toasterofbread commented 1 month ago

This is not something I'm planning for SpMp.