search

toastslack / toastbot

A hubot for toastieslack.
2 stars 7 forks source link

Replace hubot-pugme with local script #7

Open chesleylovejoy opened 7 years ago

chesleylovejoy commented 7 years ago

The external URL that sends pug image links back to the hubot-pugme script has started sending back a lot of broken links. This is a reported issue, but it's old enough that I don't think it's going to get fixed.

I'd like to look into replacing the hubot pugme script with something local where we can maintain/have control over what links are available.

hnotess commented 7 years ago

This makes complete sense to me. Would you like it to be set up the same way as pugme, where it gets the pugs from an external source (like the heroku app) or would you want it to be more like our custom toastbot scripts that just have the dataset plopped right inside?

chesleylovejoy commented 7 years ago

I think having the data inside the script is fine, and that makes it pretty easy to edit if a link goes bad. Having said that, I haven't built any link passing stuff in hubot so I don't know if there are any additional special considerations?

On Jul 13, 2017 00:27, "Hannah" notifications@github.com wrote:

This makes complete sense to me. Would you like it to be set up the same way as pugme, where it gets the pugs from an external source (like the heroku app) or would you want it to be more like our custom toastbot scripts that just have the dataset plopped right inside?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chesleylovejoy/toastbot/issues/7#issuecomment-314974632, or mute the thread https://github.com/notifications/unsubscribe-auth/AKBdX22pOM5fkXMKXMUyPuRFlh21NvNZks5sNaqxgaJpZM4OTocy .