Closed w-k-jones closed 10 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
5f096e3
) 56.68% compared to head (c137f44
) 56.77%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note that I wasn't able to use functools.wrap
with the njit_if_available
decorator because it works a bit differently to usual. If you have any ideas @freemansw1 let me know, but given that it's only used on internal functions I don't think the lack of docstrings when calling help
is a problem, unlike with the xarray conversion decorators which wrap the main user functions
Note that I wasn't able to use
functools.wrap
with thenjit_if_available
decorator because it works a bit differently to usual. If you have any ideas @freemansw1 let me know, but given that it's only used on internal functions I don't think the lack of docstrings when callinghelp
is a problem, unlike with the xarray conversion decorators which wrap the main user functions
My guess is that this is done automagically through Numba because help
returns the correct docstring; when I return func
the correct docstring is also reported.
Many thanks for this one, @w-k-jones! I went ahead and fixed the merge conflicts. When everything looks fine for you, please go ahead and merge :)
Ready to merge @w-k-jones @freemansw1 ? :)
Resolves #356 and reorganises decorators to a separate module