Closed freemansw1 closed 8 months ago
Attention: Patch coverage is 93.39623%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 57.05%. Comparing base (
7ded724
) to head (0800478
). Report is 39 commits behind head on RC_v1.5.x.
Files | Patch % | Lines |
---|---|---|
tobac/utils/decorators.py | 93.20% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch. A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.
@w-k-jones @snilsn I am ready for re-review when you are!
Ok, resolved that last comment. @w-k-jones, @snilsn ready to merge when you are.
Great! Happy for this to be merged
Great, please go ahead and merge! @freemansw1
Pulls code from #354 to allow developers to specify (with a new argument to the decorator
irispandas_to_xarray
) whether or not aniris
->xarray
conversion occurred, via a passed keyword argument.Important note: I've now changed all of our decorators to allow keyword arguments. That means that when calling decorators in the future, you must call with an empty
()
regardless of whether or not you want to use them.