Closed freemansw1 closed 9 months ago
@harrietgilmour and @w-k-jones, are you available to review this PR within the next week or so?
Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the tobathon branch. A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ed4c4bf
) 56.91% compared to head (333778b
) 56.91%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@harrietgilmour and @w-k-jones, are you available to review this PR within the next week or so?
Yes no problem. I can do it next week
@harrietgilmour and @w-k-jones, are you available to review this PR within the next week or so?
Yes no problem. I can do it next week
Thanks! Trying to be more deliberate with our review requests.
Also the docstring are wrongly formatted for seed_3D_flag
in segmentation.py
which is causing the API reference to render incorrectly. I can fix that quickly and add it to this PR
Thanks @w-k-jones @harrietgilmour !
@w-k-jones what is our policy on documentation-only PRs? We can merge these right into main
, right?
Thanks @w-k-jones @harrietgilmour !
@w-k-jones what is our policy on documentation-only PRs? We can merge these right into
main
, right?
Yes, looks like there's no issues with merging into main so I'm happy for you to do that directly
Resolves #399 and adds box seeding to our documentation for segmentation parameters.
Worked on with @RBhupi during the tobathon 2024