tobac-project / tobac

Tracking and object-based analysis of clouds
BSD 3-Clause "New" or "Revised" License
99 stars 53 forks source link

Corrected error and warnings for bulk statistics when feature labels do not match labels in segmentation mask #448

Open JuliaKukulies opened 1 week ago

JuliaKukulies commented 1 week ago

Solves #446

github-actions[bot] commented 1 week ago

Linting results by Pylint:

Your code has been rated at 8.73/10 (previous run: 8.73/10, +0.00) The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch. A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.99%. Comparing base (3609a59) to head (ab0420b). Report is 24 commits behind head on RC_v1.5.x.

Files with missing lines Patch % Lines
tobac/feature_detection.py 66.66% 1 Missing :warning:
tobac/utils/bulk_statistics.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## RC_v1.5.x #448 +/- ## ============================================= + Coverage 60.96% 60.99% +0.03% ============================================= Files 23 23 Lines 3548 3551 +3 ============================================= + Hits 2163 2166 +3 Misses 1385 1385 ``` | [Flag](https://app.codecov.io/gh/tobac-project/tobac/pull/448/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tobac-project/tobac/pull/448/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project) | `60.99% <81.81%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JuliaKukulies commented 1 week ago

Tests should be OK after merge of #451