search

tobac-project / tobac

Tracking and object-based analysis of clouds
BSD 3-Clause "New" or "Revised" License
102 stars 54 forks source link

updated v1.5 reference to peer-reviewed #450

Closed JuliaKukulies closed 1 month ago

JuliaKukulies commented 1 month ago

Updated the reference and thereby solved #445

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.96%. Comparing base (4fa1efa) to head (ad60ed7). Report is 33 commits behind head on RC_v1.5.x.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## RC_v1.5.x #450 +/- ## ============================================= - Coverage 60.98% 60.96% -0.03% ============================================= Files 23 23 Lines 3550 3548 -2 ============================================= - Hits 2165 2163 -2 Misses 1385 1385 ``` | [Flag](https://app.codecov.io/gh/tobac-project/tobac/pull/450/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tobac-project/tobac/pull/450/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project) | `60.96% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tobac-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch. A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

w-k-jones commented 1 month ago

It would be nice to add the publications to the top of the "Refereed Publications" page, but I'm happy to approve this as is

JuliaKukulies commented 1 month ago

It would be nice to add the publications to the top of the "Refereed Publications" page, but I'm happy to approve this as is

Agree, I will add this!

JuliaKukulies commented 1 month ago

Thanks, @JuliaKukulies. For the issue in utils, is there an issue number linked to it? If so, let's make sure to mark it with the milestone and close it too.

As for the utils fixes: this was done in the already closed PR of Will #451 (issue #444). It just ended up here as well since there was a time mismatch and I have then merged in the changes from #451 to this PR so the matrix testing is fixed

JuliaKukulies commented 1 month ago

@freemansw1 Since the issue that was related to these merged in changes is closed, I am merging this now